One hundred years have passed since Warburg discovered alterations in cancer metabolism, more than 70 years since Sidney Farber introduced anti-folates that transformed the treatment of childhood leukaemia, and 20 years since metabolism was linked to oncogenes. However, progress in targeting cancer metabolism therapeutically in the past decade has been limited. Only a few metabolism-based drugs for cancer have been successfully developed, some of which are in — or en route to — clinical trials. Strategies for targeting the intrinsic metabolism of cancer cells often did not account for the metabolism of non-cancer stromal and immune cells, which have pivotal roles in tumour progression and maintenance. By considering immune cell metabolism and the clinical manifestations of inborn errors of metabolism, it may be possible to isolate undesirable off-tumour, on-target effects of metabolic drugs during their development. Hence, the conceptual framework for drug design must consider the metabolic vulnerabilities of non-cancer cells in the tumour immune microenvironment, as well as those of cancer cells. In this Review, we cover the recent developments, notable milestones and setbacks in targeting cancer metabolism, and discuss the way forward for the field.